This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Add a combinator then_or_not to optionally run a parser after another#733
Open
senioria wants to merge 1 commit intozesterer:mainfrom
Open
Add a combinator then_or_not to optionally run a parser after another#733senioria wants to merge 1 commit intozesterer:mainfrom
then_or_not to optionally run a parser after another#733senioria wants to merge 1 commit intozesterer:mainfrom
Conversation
Owner
I'm not sure I follow this logic. Optional type annotations can be expressed perfectly well (I've been doing so in my own lang for years) with the following let pat = ... ; // Pattern
let ty = ... ;// Type annotation
text::keyword("let").padded()
.ignore_then(pat)
.then(just(":").padded().ignore_then(ty).or_not())
.then_ignore(just("=").padded())
.then(...)Chumsky doesn't get confused by this, and the fact that the error is suppressed when parsing fails is not a problem: chumsky will still remember that the error could have been hit and will make use of that information when generating the final syntax error. |
Owner
|
Is this still an API hole for you, or is my suggested solution sufficient? |
zesterer
force-pushed
the
main
branch
5 times, most recently
from
38bb88c to
02a1373
Compare
zesterer
force-pushed
the
main
branch
2 times, most recently
from
0f2b61a to
e350fc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #630, which first mentioned something like this.
This can be used in syntaxes like Rust's let statement, which has an optional type notation:
.then(...).or_not()doesn't work well in such cases, because when there's a parse error in the type,or_notwould just suppress it and returnNone, leaving the following parsers confusing, or even worse, mistakenly starting parsing from the wrong position. In this particular example, when the type has an error, the parser may complain something likeexpected '=', got ':', rather than pointing out the error in the type.With
then_or_not, Rust's let statement can roughly be parsed with:And this would correctly report the errors in
rust_typeandexpr.